Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new hover states, items for widget menus #5090

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Adds new hover states, items for widget menus #5090

merged 1 commit into from
Apr 1, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 30, 2020

Fixes: brave/brave-browser#8883

Submitter Checklist:

Test Plan:

Behavior is defined in the issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.8.x - Nightly milestone Mar 30, 2020
@ryanml ryanml requested review from bbondy and cezaraugusto March 30, 2020 00:58
@ryanml ryanml self-assigned this Mar 30, 2020
@ryanml ryanml force-pushed the fix-8883 branch 4 times, most recently from 5e5f9e9 to d77877a Compare March 31, 2020 21:55
@ryanml ryanml requested a review from cezaraugusto March 31, 2020 21:59
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml force-pushed the fix-8883 branch 2 times, most recently from bd1e425 to bb08940 Compare April 1, 2020 03:03
@ryanml ryanml added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Apr 1, 2020
@ryanml ryanml merged commit cb7fc7d into master Apr 1, 2020
@ryanml ryanml deleted the fix-8883 branch April 1, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/newtab
Projects
None yet
2 participants